RE: wjed B0.9.17-56 and slang2-pre2-rc3 patches

[SANGOI DINO <SANGOID@xxxxxxxxxxxxxxxxx>]

[Answering an old but interesting post] 

> -----Original Message-----
> From: Marko Mahnic [mailto:marko.mahnic@xxxxxxxx] 
> Sent: venerdì 28 gennaio 2005 15.30
> Subject: Re: wjed B0.9.17-56 and slang2-pre2-rc3 patches
> 
> 
> In my opinion when redrawing the screen in wjed (and also in 
> xterm), jed should not be using tt_write! It should just read 
> data from VTerm_display and output that data to the device context.
> 
> There should be a function like:
> 
>    draw_term_rc(int row, int column, int nchars)
>    {
>       loop
>         ... read data from VTerm_Display
>         ... write data to DC
>    }
> 
> that reads characters from VTerm_Display and writes them to DC.
> 
> outline for tt_write:
> 
> void tt_write (char *s, int n)
> {
>     vterm_write_nchars (s, (unsigned int) n);
>     draw_term_rc(CursorRow, CursorCol, n);
>     CursorCol += n;
> }
> 
> outline for cover_exposed_area:
> 
> void cover_exposed_area()
> {
>     for each line
>       draw_term_rc (lineno, 0, screen_width) }
> 

I completely agree with you, I've tried it before posting my patch, and it
didn't work. It's not so easy because cover_exposed_area() calls
send_attr_str(), and this function is called also by msw_smart_puts() to
write to Vterm. So changing this means duplicating send_attr_str(),
msw_write_smgchars() and msw_reverse_video(). 

It is doable, but as Jed still calls wterm functions to write to Vterm, I
don't see a big win here.

Much better would be if jed writes directly to Vterm and then calls a
function to say: you should redraw this,  but it's not like it works today,
and changing it may not be so easy (most calls starts inside slsmg in
slang).

Later,
					Dino



--------------------------
To unsubscribe send email to <jed-users-request@xxxxxxxxxxx> with
the word "unsubscribe" in the message body.
Need help? Email <jed-users-owner@xxxxxxxxxxx>.