Re: wjed B0.9.17-56 and slang2-pre2-rc3 patches

["John E. Davis" <davis@xxxxxxxxxxxxx>]

SANGOI DINO <SANGOID@xxxxxxxxxxxxxxxxx> wrote:
>The first problem arises while trying to compile slang2. In the file
>'makefile.all', while creating the 'response file', the overwriting
>redirection (>) is used for some object names instead of appending
>redirection (>>). This way the response doesn't contains all the needed
>files, and linking Jed against this library fails complaining about a lot of
>symbols undefined.

I should have caught this problem much earlier.  Thanks for picking up
on it.

>After this patch, both jed and wjed can be compiled without problems. But
>while redrawing lines with different colors (e.g. a syntax highlighted C or
>SLang code), wjed writes only the characters with the first color. After a
>bit of debugging, I found the problem: for redrawing wjed does a loop on
>VTerm_Display lines, and for every lines, scans characters until the color
>changes, and then uses 'tt_write', the same function used to write for the
>first time. tt_write calls vterm_write_nchars() to store the new chars in
>VTerm_Display, but before writing the new data, tt_write clears all the
>remaining line with a memset(). But this is the same line that

Another mistake on my part.  There is a related problem that your
patch did not catch.  In wterm.c, the cover_exposed_area should be
patched as follows:

--- wterm.c~	Sun Nov 21 22:47:42 2004
+++ wterm.c	Fri Jan 28 22:22:35 2005
@@ -1483,6 +1483,7 @@
    if (VTerm_Display==NULL) return;
 
    Performing_Update++;
+   VTerm_Suspend_Update++;
    hide_cursor ();
    save_row = This_Window.cursor_row;
    save_col = This_Window.cursor_col;
@@ -1503,6 +1504,7 @@
 	row++;
      }
    msw_goto_rc (save_row, save_col);
+   VTerm_Suspend_Update--;
    Performing_Update--;
 
    show_cursor ();
   
[...]
>I'm still have to try wjed with utf-8 files.

You mill find that more work is required in both vterm.c and wterm.c
to get wjed to support unicode.

Thanks,
--John

--------------------------
To unsubscribe send email to <jed-users-request@xxxxxxxxxxx> with
the word "unsubscribe" in the message body.
Need help? Email <jed-users-owner@xxxxxxxxxxx>.