Re: More patches

[Jörg Sommer <joerg@xxxxxxxxxxxx>]

Hallo G.,

"G. Milde" <milde@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On 20.05.08, J�rg Sommer wrote:
>
> If I got this right, than 
>
> * the "changed syntax of require()" problem is fixed,
>
> * jed 0.99 now uses slang_load_path() instead of jed_library_path() for
>   both, require() and evalfile().

Yes.

> * a patch in site.sl will alias (s|g)et_jed_library_path() to
>   (s|g)et_slang_load_path().

Yes.

> Then this issue should be solved. (There might be others.)

No, it doesn't. I've forgot I'm using this patch for 50jed-extra.sl

diff --git a/jed.d/50jed-extra.sl b/jed.d/50jed-extra.sl
index b4e547b..e00a95d 100644
--- a/jed.d/50jed-extra.sl
+++ b/jed.d/50jed-extra.sl
@@ -13,6 +13,8 @@ $2 = path_concat($1, "libdir.sl");
 #stop
 #endif
 
+set_slang_load_path($1 + "drop-in:" + get_slang_load_path() + ":$1/utils:$1"$);
+
 % Add (and initialize) library directories
 % ----------------------------------------
 

Without it the jed-extra directories aren't in the load path.

>> > Could you run the jedmodes unit tests with 0.99 and tell me about any
>> > errors (or just mail a testreport)? There is a utility script in
>> > jed-extra/trunk/utils/do-unittests.sh.
>
>> I will do so, tomorrow.
>
> Fine.

All tests fail with the error message ‘view_mode is undefined.’ I've
added this patch and now the test exits with the return value 20.

Index: do-unittests.sh
===================================================================
--- do-unittests.sh     (Revision 1112)
+++ do-unittests.sh     (Arbeitskopie)
@@ -21,12 +21,12 @@
 TESTFUN='test_files_and_exit("/usr/share/jed/jed-extra/tests/*.sl")'
 
 # jed (without X)
-LANG=en_US; jed -n -l extra/unittest.sl -f $TESTFUN
+LANG=en_US; jed -n -l view -l extra/unittest.sl -f $TESTFUN
 
 # xjed and standard emulation (usually emacs)   
-LANG=en_US; xjed -n -l extra/unittest.sl -f $TESTFUN
+LANG=en_US; xjed -n -l view -l extra/unittest.sl -f $TESTFUN
 
 # unicode enabled xjed
-LANG=en_US.UTF-8; xjed -n -l extra/unittest.sl -f $TESTFUN
+LANG=en_US.UTF-8; xjed -n -l view -l extra/unittest.sl -f $TESTFUN
 
 

Bye, Jörg.
-- 
Manchmal denke ich, das sicherste Indiz dafür, daß anderswo im Universum
intelligentes Leben existiert, ist, daß niemand versucht hat, mit uns
Kontakt aufzunehmen.                           (Calvin und Hobbes)

--------------------------
To unsubscribe send email to <jed-users-request@xxxxxxxxxxx> with
the word "unsubscribe" in the message body.
Need help? Email <jed-users-owner@xxxxxxxxxxx>.