Re: _jed_set_mode_hooks not called by compression mode

["G. Milde" <g.milde@xxxxxx>]

On 10.04.06, Jörg Sommer wrote:
> Hello G.,
> 
> "G. Milde" <g.milde@xxxxxx> wrote:
> > There is no way a "find-file-before-hook" can mark it's success but request
> > the _jed_find_file_after_hooks to be run.
> >
> > 2. Provide a function to run a "hook chain", say
> >
> >       run_hooks("_jed_find_file_after_hooks");
> 
> Where is the problem with _jed_run_hooks?

 1. It is not mentioned in Help>Browse_Docs>hooks.
 
 2. It is not in the 'SEE ALSO' section of add_to_hook, append_to_hook,
    and remove_from_hook.

 3. _jed_run_hooks: intrinsic function  Undocumented

Anyway, thanks a lot for the tip. 

So, a line

  _jed_run_hooks("_jed_find_file_after_hooks");

at the right place in compress.sl would cure the bug?


> > I would prefer the second solution, as it is more generic
> > (i.e. could also be used outside of a hook).
> 
> I would prefer that find_file calls the hooks. This is more generic.

We would need a third return value then, as in some cases it might be
that a find-file-before-hook really wants the file-finding aborted and no
find-file-after-hooks called (i.e. the current behaviour).

With _jed_run_hooks() already existing I find it simpler to add
documentation refering to _jed_run_hooks() in hooks.txt than to add (and
document) one more possible return value to "_jed_find_file_before_hooks"
hooks.

Guenter

--------------------------
To unsubscribe send email to <jed-users-request@xxxxxxxxxxx> with
the word "unsubscribe" in the message body.
Need help? Email <jed-users-owner@xxxxxxxxxxx>.